Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d59ac5e
Roll skia on m138 (canvaskit/0.40.0-456-g114d33c629 to canvaskit/0.40…
HinTak Jun 25, 2025
45ece54
Upgrade skia to m139 (canvaskit/0.40.0-457-ga46d5732d9 to canvaskit/0…
HinTak Jun 25, 2025
28d707b
Bump version up to 139.0
HinTak Jun 25, 2025
76c1c52
m139 patch plus adjustments
HinTak Jun 25, 2025
d9b3d4f
m139 changes
HinTak Jun 25, 2025
cd8af0c
Upstream main (post m139) fix for pdf breakage
HinTak Jun 25, 2025
e1b58ee
Revert "Backporting skia m139 fix to earlier skia for arm64 windows +…
HinTak Jun 26, 2025
6c911d9
Roll skia along m139 (canvaskit/0.40.0-787-g0f94c19331 to canvaskit/0…
HinTak Aug 6, 2025
443a499
Skip pybind11 3.0.0 until it get fixed (waiting for 3.0.1)
HinTak Aug 10, 2025
ce1ba85
Windows pip does not like single quotes
HinTak Aug 11, 2025
9a57666
Windows pip does not like single quotes - 2nd change
HinTak Aug 11, 2025
f160ab1
Use x64_64 gn binary for arm64 windows
HinTak Aug 11, 2025
3b18469
Can need apt-get update first before finding the correct packages
HinTak Aug 12, 2025
50924a6
Roll skia on m139 (canvaskit/0.40.0-795-gcbc694239b to canvaskit/0.40…
HinTak Sep 6, 2025
4af853a
Rolll skia along m139 (canvaskit/0.40.0-797-g4abe0638e3 to canvaskit/…
HinTak Dec 8, 2025
f8ee1ae
Filling in VkFormat and VkImageLayout values
Feb 26, 2026
a0d7a83
No need to have py::arithmetic() or py::implicitly_convertible for Vk…
Feb 26, 2026
c25e729
Adjusting Vulkan tests to use symbolic enums
Feb 26, 2026
6277017
Fix build error against pybind11 3.0.2.
Feb 17, 2026
5cece21
Merge branch 'm139-public' of github.com:HinTak/skia-python into m139…
HinTak Feb 27, 2026
be72c38
CI: Update to macos-14
HinTak Dec 8, 2025
8163cfa
CI: use macos-15-intel to get a x64 build for auto64.
HinTak Dec 9, 2025
3b8be26
Reverting pybind11 3.0.0 limits - it should just work now.
HinTak Feb 28, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2022, macos-13]
os: [ubuntu-22.04, windows-2022, macos-15-intel]
arch: [auto64]
cp: ["cp3{10,11,12,13}"]
include:
- os: macos-13
- os: macos-14
arch: arm64
cp: "cp3{10,11,12,13}"
- os: ubuntu-22.04-arm
Expand Down Expand Up @@ -66,11 +66,11 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2022, macos-13]
os: [ubuntu-22.04, windows-2022, macos-15-intel]
arch: [auto64]
cp: ["cp3{8,9}"]
include:
- os: macos-13
- os: macos-14
arch: arm64
cp: "cp3{8,9}"
- os: ubuntu-22.04-arm
Expand Down Expand Up @@ -127,6 +127,7 @@ jobs:
- name: Build docs
run: |
# installing libegl1 will also install libegl-mesa0
sudo apt-get -y update
sudo apt-get -y install libegl1
python -m pip install --pre -f dist skia-python
python -m pip install sphinx sphinx-rtd-theme
Expand Down
210 changes: 210 additions & 0 deletions patch/0001-Revert-gn-Split-pdf-and-xps-from-skia.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,210 @@
From e5b9496b71237d3e63289c6fd8a7466d8db80a29 Mon Sep 17 00:00:00 2001
From: Florin Malita <[email protected]>
Date: Mon, 23 Jun 2025 19:07:15 -0700
Subject: [PATCH] Revert "[gn] Split :pdf and :xps from :skia"

This reverts commit 3f34cf7c2d940a9ed84bf131d6c33b7380e180a0.

Reason for revert: breaking Android

Original change's description:
> [gn] Split :pdf and :xps from :skia
>
> After https://skia-review.googlesource.com/c/skia/+/1008277/2, we end up
> with an implicit dependency cycle:
>
> :skia -> :pdf/:xps (SkClipStack_AsPath) -> //modules/pathops -> :skia
>
> To fix, remove pdf and xps deps from "core" :skia and add to leaf apps
> instead.
>
> Change-Id: Ibdd58a97672ab5f9566c71907ce9e664eb809d4a
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1009616
> Reviewed-by: Ben Wagner <[email protected]>
> Commit-Queue: Florin Malita <[email protected]>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I259449122b1b77894e841d3146487f5be8bebfba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1011517
Auto-Submit: Florin Malita <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Signed-off-by: Hin-Tak Leung <[email protected]>
---
BUILD.gn | 41 ++++++-------------------------------
bazel/exporter_tool/main.go | 4 ----
gn/utils.gni | 6 ------
3 files changed, 6 insertions(+), 45 deletions(-)

diff --git a/BUILD.gn b/BUILD.gn
index 0cdde0edfa..acdfb6d793 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1257,22 +1257,12 @@ optional("graphite") {
}
}

-skia_component("clipstack_utils") {
- deps = [
- ":skia",
- "//modules/pathops",
- ]
- sources = skia_clipstack_utils_sources
-}
-
optional("pdf") {
- enabled = skia_use_zlib && skia_enable_pdf
+ enabled = skia_use_zlib && skia_enable_pdf && skia_use_libjpeg_turbo_decode &&
+ skia_use_libjpeg_turbo_encode
public_defines = [ "SK_SUPPORT_PDF" ]

- deps = [
- ":clipstack_utils",
- "//third_party/zlib",
- ]
+ deps = [ "//third_party/zlib" ]
public = skia_pdf_public
sources = skia_pdf_sources
sources_when_disabled = [ "src/pdf/SkDocument_PDF_None.cpp" ]
@@ -1296,7 +1286,6 @@ optional("pdf_jpeg_helpers") {
optional("xps") {
enabled = skia_use_xps && is_win
public_defines = [ "SK_SUPPORT_XPS" ]
- deps = [ ":clipstack_utils" ]
public = skia_xps_public
sources = skia_xps_sources
}
@@ -1672,8 +1661,11 @@ skia_component("skia") {
":gpu",
":graphite",
":jpeg_encode",
+ ":pdf",
+ ":pdf_jpeg_helpers",
":png_encode_libpng",
":webp_encode",
+ ":xps",
]

deps = [
@@ -1731,10 +1723,6 @@ skia_component("skia") {
"src/sfnt/SkOTUtils.cpp",
]

- # TODO(fmalita): remove from skia_utils_private after clients are migrated to
- # skia_clipstack_utils_sources
- sources -= skia_clipstack_utils_sources
-
defines = []
libs = []

@@ -1950,8 +1938,6 @@ if (skia_enable_tools) {
deps = [
":flags",
":gpu_tool_utils",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":skia.h",
"modules/pathops",
@@ -2558,8 +2544,6 @@ if (skia_enable_tools) {
":flags",
":gm",
":gpu_tool_utils",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":tool_utils",
"modules/skparagraph:bench",
@@ -2632,13 +2616,10 @@ if (skia_enable_tools) {
":gm",
":gpu_tool_utils",
":hash_and_encode",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":tests",
":tool_utils",
":trace",
- ":xps",
"modules/pathops",
"modules/skottie",
"modules/skottie:utils",
@@ -2751,8 +2732,6 @@ if (skia_enable_tools) {
test_app("sktexttopdf") {
sources = [ "tools/using_skia_and_harfbuzz.cpp" ]
deps = [
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
"modules/pathops",
"modules/skshaper",
@@ -2853,8 +2832,6 @@ if (skia_enable_tools) {
deps = [
":flags",
":gpu_tool_utils",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
"modules/jsonreader",
"modules/skottie:fuzz",
@@ -2903,8 +2880,6 @@ if (skia_enable_tools) {
]
deps = [
":gm",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":tests",
":tool_utils",
@@ -3084,8 +3059,6 @@ if (skia_enable_tools) {
]
}
deps = [
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":skia.h",
"modules/skottie",
@@ -3306,8 +3279,6 @@ if (skia_enable_tools) {
deps += [
":flags",
":gpu_tool_utils",
- ":pdf",
- ":pdf_jpeg_helpers",
":skia",
":tool_utils",
]
diff --git a/bazel/exporter_tool/main.go b/bazel/exporter_tool/main.go
index 77bc549ece..5201da4220 100644
--- a/bazel/exporter_tool/main.go
+++ b/bazel/exporter_tool/main.go
@@ -449,10 +449,6 @@ var gniExportDescs = []exporter.GNIExportDesc{
"//src/utils:utils_skslc_hdrs",
"//src/utils:utils_skslc_srcs",
}},
- {Var: "skia_clipstack_utils_sources",
- Rules: []string{
- "//src/utils:clip_stack_utils",
- }},
},
},
{GNI: "gn/xps.gni", Vars: []exporter.GNIFileListExportDesc{
diff --git a/gn/utils.gni b/gn/utils.gni
index 42255ce6a3..080f89c98e 100644
--- a/gn/utils.gni
+++ b/gn/utils.gni
@@ -120,9 +120,3 @@ skia_utils_private = [
"$_src/utils/win/SkTScopedComPtr.h",
"$_src/utils/win/SkWGL_win.cpp",
]
-
-# Generated by Bazel rule //src/utils:clip_stack_utils
-skia_clipstack_utils_sources = [
- "$_src/utils/SkClipStackUtils.cpp",
- "$_src/utils/SkClipStackUtils.h",
-]
--
2.49.0

146 changes: 0 additions & 146 deletions patch/0001-gn-Remove-msvc-env-setting.patch

This file was deleted.

Loading
Loading