M139 public#342
Merged
Merged
Conversation
….0-457-ga46d5732d9)
….40.0-787-g0f94c19331)
… freetype compatibility." This reverts commit bfccc58.
….40.0-795-gcbc694239b)
Collaborator
Author
|
The CI failure is pybind/pybind11#5694 , I think, and pybind11 3.0.0 is out. |
….0-797-g4abe0638e3)
…0.40.0-799-g87d8e1a22e)
Fixes skia-python#350 See skia-python#350 Segfault on pytest exit in CI against pybind11 3.0.1 This is a workaround. See upstream issues: pybind/pybind11#5976 [BUG]: Crash due to invalid free during cleanup, if any enum is registerd, due to attempting to free a string literal pybind/pybind11#5991 [BUG]: segfault at exit since upgrading to 3.0.x, probably due to "Make wrapped C++ functions pickleable" (pybind/pybind11#5580) Signed-off-by: Hin-Tak Leung <[email protected]>
…Format and VkImageLayout Signed-off-by: Hin-Tak Leung <[email protected]>
Signed-off-by: Hin-Tak Leung <[email protected]>
src/skia/Matrix.cpp:1562:13: error: return type 'Tuple<int, int>' must match previous return type
'Tuple<float &, float &>' when lambda expression has unspecified explicit return type
1562 | return py::make_tuple(-1, -1);
| ^
1 error generated.
Signed-off-by: Hin-Tak Leung <[email protected]>
See actions/runner-images#13046 macOS 13 is fully unsupported by December 4th 2025 for GitHub.
Revert "Skip pybind11 3.0.0 until it get fixed (waiting for 3.0.1)" This reverts commit 443a499.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m139 is quite bad - a lot of under-the-hood changes, and re-org of components. This I think builds but does not load at runtime - likely needs some new stuff like skia_use_pdf to load.