Binding SkFontMgr_New_Custom_Directory#292
Merged
HinTak merged 4 commits intoFeb 5, 2025
Merged
Conversation
This was referenced Dec 25, 2024
Collaborator
Author
|
Github CI seems to have a regression - Intel mac os isn't able to get at the Apple Color Emoji font (arm mac os is successful) - it is failing at an unrelated test that passed at v132 a few weeks ago. I am just re-running the failed job. It is probably transient. |
Collaborator
Author
|
Reproduced the failure with fork sync and identified the problematic image upgrade, so filed actions/runner-images#11241 for the CI failure. Re-run failed job when upstream fixes that, I guess. |
Collaborator
Author
|
There is a problem with mac os python 3.13.1 build at the moment - actions/runner-images#11241 . |
See python/cpython#128161 "Defining iterator in a separate class no longer works in 3.13" We have iterator for SkTextBlob defined by SkTextBlob::Iter(textblob), which is the c++/pybind11 equivalent of the same situation. Following the suggestion: python/cpython#128161 (comment) Also see actions/runner-images#11241 Fixes skia-python#295
…_New_Custom_Directory
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is complete as is. I intend to pull this into m134, so no need for any immediate action.
The new API seems to be recursive - it scans subdirectories.
Fixes #291