Skip to content

M131 public py3.13 2nd try#275

Merged
HinTak merged 14 commits into
skia-python:mainfrom
HinTak:m131-public-py3.13-2nd-try
Nov 14, 2024
Merged

M131 public py3.13 2nd try#275
HinTak merged 14 commits into
skia-python:mainfrom
HinTak:m131-public-py3.13-2nd-try

Conversation

@HinTak
Copy link
Copy Markdown
Collaborator

@HinTak HinTak commented Oct 24, 2024

Tidied up from #273 . Includes #272 (and #267 )

There is only one commit beyond #272 - it splits the cibuildwheel job into two, one for 3.10 to 3.13, another for 3.8 and 3.9. Wastes CPU time by building skia unnecessarily 4 times I think, but this is marginally faster than the current 3.8 to 3.12 build, because there is more parallelism as we do 3.8/3.9 vs 3.10-3.13 in parallel.

Fixes #230 for the near future, I think.

Refining earlier change (skia-python#214). It turns out that Xvfb's GL behavior on Linux
differ depending on whether there is actual graphic hardware or entirely
headless. The Apple GL settings works on Xvfb on my computer
(AMD Radeon R5 Graphics), but fails in github headless CI.

Fixes skia-python#266
Milestone 130
-------------
  * Ganesh files have been moved out of include/gpu/ into include/gpu/ganesh/. Shims have been left in place, but clients should migrate to the new paths.
…was never used

google/skia@16722e4
Revert "Allow passing multiple node IDs per PDF structure node."

    This reverts commit 2a016ba.
    StructureElemementNode::fAdditionalNodeIds is currently unused and
    appears to never have been used.

    Change-Id: If2c1aae88909dc3ec701e94008108e2dc02504bb
    Reviewed-on: https://skia-review.googlesource.com/c/skia/+/905896
…ng icudtl.dat+MakeFromShapedText failure

Conflicts:
	tests/test_font.py
Split CI machinery into two nearly identical sections, one for 3.8/3.9,
another for 3.10 to 3.13. This is mainly due to newer cibuildwheel for
3.13 dropping 3.8 and 3.9, and older cibuildwheel not supporting 3.13.

Fixes skia-python#230
@HinTak HinTak mentioned this pull request Oct 24, 2024
This was referenced Oct 25, 2024
@theacodes
Copy link
Copy Markdown

Hi 👋🏻 , I'm a downstream user of skia-python that's eager to upgrade to Python 3.13. Is there anything I can do to help this along? I'm happy to test it out, review the PR, or just offer encouragement. 😄

@HinTak
Copy link
Copy Markdown
Collaborator Author

HinTak commented Oct 31, 2024

@theacodes thanks for the offer. There is nothing needed on this pull itself: we basically release the next skia-python when the next upstream skia comes out. That should be in about a week or two; so you just need to wait about two weeks max. This will likely be merged with #274, which has a lot more exciting new stuff in. Give that a try - you can download pre-built wheels from https://github.com/kyamagu/skia-python/actions for either this pull or #274 , if you want to test out either the vanilla python 3.13 builds, or the SKRuntimeEffect binding builds (still with 3.12). Lastly, you can always buy me a coffee under the sponsor/donate link on my profile.

Btw, this will merge with #274 first, and #274 being the main merge, for the next release.

@theacodes
Copy link
Copy Markdown

Thank you! I'll give things a try and let you know if I run into issues. Appreciate all your work!

@HinTak
Copy link
Copy Markdown
Collaborator Author

HinTak commented Oct 31, 2024

@theacodes from the other stuff you do, it looks like you might be interested the new runtime effect functionality - I only have a few static examples, but I think it should be possible to do animated graphics effect with it. Like a pulsating heart or rippling water/waves, or something. Get some inspiration from some of the opengl shader demos on youtube and port them to skia SKSL for some visual effect, if that intetests you.

@HinTak HinTak mentioned this pull request Nov 3, 2024
@m4rc1e
Copy link
Copy Markdown

m4rc1e commented Nov 6, 2024

Thank you very much for your work on this HinTak! LGTM.

@HinTak HinTak mentioned this pull request Nov 13, 2024
@HinTak HinTak merged commit f65d73d into skia-python:main Nov 14, 2024
@HinTak HinTak deleted the m131-public-py3.13-2nd-try branch November 14, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecation of distutilsupstream for python >= 3.12

3 participants