Skip to content

Added watchtower - #10522

Merged
PeterShaggyNoble merged 5 commits into
simple-icons:developfrom
nirvikpurkait:add-new-icons/watch-tower
Mar 15, 2024
Merged

PeterShaggyNoble merged 5 commits into
simple-icons:developfrom
nirvikpurkait:add-new-icons/watch-tower

Conversation

@nirvikpurkait

Copy link
Copy Markdown
Contributor

image

Issue: closes #10478

Similarweb rank:
839,752

Consideration:

Github start: 16.3k
Repository is still active
star history is upward trajectory

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions Bot added the new icon Issues or pull requests for adding a new icon. label Feb 24, 2024
@nirvikpurkait

nirvikpurkait commented Feb 24, 2024 •

Copy link
Copy Markdown
Contributor Author

Every test, lint passed locally, github action failed due to:

FetchError: request to https://github.com/editorconfig-checker/editorconfig-checker/releases/download/2.8.0/ec-linux-amd64.tar.gz failed, reason: connect ETIMEDOUT 140.82.112.3:443

Can we re-run the checks?

@LitoMore

Copy link
Copy Markdown
Member

Hi @nirvikpurkait, it should be a connection issue related to your local environment. As you can see the HTTP request timed out when connecting to a GitHub public URL.

You can use npm run svglint command to run SVG linters only to bypass the EditorConfig Checker.

Comment thread _data/simple-icons.json Outdated

@PeterShaggyNoble PeterShaggyNoble left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as manual vectorisations go, this is nigh on perfect - very nice work, @nirvikpurkait 👍🏻

It does line up a little better if the height is resized to 24dp but I don't thing the differences are significant enough to block us from merging this as-is, but I'll ask one of the @simple-icons/pr-reviewers to throw another eye over it, too.

For the colour, I think we should go with #2d383e, which is the website's background colour - what do you reckon?

@PeterShaggyNoble
PeterShaggyNoble requested a review from a team March 14, 2024 16:42
@service-paradis

Copy link
Copy Markdown
Member

As far as manual vectorisations go, this is nigh on perfect - very nice work, @nirvikpurkait 👍🏻

It does line up a little better if the height is resized to 24dp but I don't thing the differences are significant enough to block us from merging this as-is, but I'll ask one of the @simple-icons/pr-reviewers to throw another eye over it, too.

For the colour, I think we should go with #2d383e, which is the website's background colour - what do you reckon?

Looks good to me, good job @nirvikpurkait 🎉!

For the color I would opt for the header background color (#416271). It stays the same in light mode or dark mode and is called --md-primary-fg-color in their stylesheet.

Comment thread _data/simple-icons.json Outdated
@PeterShaggyNoble
PeterShaggyNoble merged commit e4a4544 into simple-icons:develop Mar 15, 2024
@nirvikpurkait
nirvikpurkait deleted the add-new-icons/watch-tower branch March 16, 2024 09:07
mondeja added a commit that referenced this pull request Mar 17, 2024
# New Icons

- Anycubic (#10466) (@adamrusted)
- BuySellAds (#10517) (@adamrusted)
- Cheerio (#10462) (@adamrusted)
- Cloudflare Workers (#10579) (@uncenter)
- Clubforce (#10249) (@PeterShaggyNoble)
- Elegoo (#10467) (@adamrusted)
- EndeavourOS (#7931) (@LitoMore)
- Flashforge (#10584) (@ApexDevelopment)
- Fueler (#10015) (@namrata18s)
- Google Authenticator (#10454) (@PeterShaggyNoble)
- Google Chronicle (#10548) (@durgeshgowdac)
- Li-Ning (#10544) (@Mvlprem)
- Lucia (#10625) (@uncenter)
- Malt (#9213) (@Ash-Crow)
- Pixelfed (#10526) (@adamrusted)
- Rich (#10329) (@PeterShaggyNoble)
- Spaceship (#9721) (@zcraber)
- TrueUp (#10582) (@durgeshgowdac)
- Watchtower (#10522) (@nirvikpurkait)
- Xiaohongshu (#10128) (@LitoMore)
- Zed Industries (#10563) (@uncenter)

# Updated Icons

- Air India (#9322) (@wwwescape)
- Logitech (#10430) (@adamrusted)
- Western Digital (#10415) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new icon Issues or pull requests for adding a new icon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Watchtower

5 participants