Skip to content

LT-22314: Create new media line for interlinear display#720

Merged
aror92 merged 2 commits intorelease/9.3from
LT-22314-interlinear-medialine
Mar 5, 2026
Merged

LT-22314: Create new media line for interlinear display#720
aror92 merged 2 commits intorelease/9.3from
LT-22314-interlinear-medialine

Conversation

@aror92
Copy link
Copy Markdown
Contributor

@aror92 aror92 commented Mar 3, 2026 •
edited
Loading

Summary

Includes support for playing audio file segments

This supports the following workflows:

  1. Clicking the play button plays the segment.
  2. Clicking the same play button, while the segment is still playing, will stop playing.
  3. Clicking a different play button, while a segment is still playing, will stop playing the current segment and start playing the new one.
  4. While the audio is playing the user can continue to work in the gui. If the user does something that disposes the InterlinDocForAnalysis, then the audio will stop.

Handles bidi and display of line in multiple writing systems

Displays a no media message instead of the audio play button/info if there is no media file.

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally: 
    git fetch origin
git log --check --pretty=format:"---% h% s" origin/<base>..
git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).

This change is Reviewable

@github-actions

This comment has been minimized.

Sign in to view
@aror92 aror92 force-pushed the LT-22314-interlinear-medialine branch 2 times, most recently from 81c6b0a to c6e8750 Compare March 3, 2026 19:01
@aror92 @mark-sil
Create new media line for interlinear display
55b3c50 
Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Handles bidi and display in multiple writing systems

Displays a no media message instead of the audio play
button/info if there is no media file.

Co-Authored-By: mark-sil <[email protected]>
Change-Id: I5f415967f76079bd16f9bd0f553abd6d9e122423
@aror92 aror92 force-pushed the LT-22314-interlinear-medialine branch from c6e8750 to 55b3c50 Compare March 3, 2026 19:32
@jasonleenaylor
Copy link
Copy Markdown
Contributor

jasonleenaylor commented Mar 3, 2026

Src/LexText/Interlinear/ITextStrings.resx line 368 at r3 (raw file):

    <value>End</value>
  </data>
  <data name="ksEndTimeOffset_" xml:space="preserve">

I don't think we need these trailing space resources do we?

@aror92
Remove unused label resources
4d6c457 
Change-Id: Ida9c4ce4b31b80d4a4fbde9dccfe99e130e2d042
jasonleenaylor
jasonleenaylor approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 9 files and all commit messages, and made 2 comments.
Reviewable status: 9 of 12 files reviewed, all discussions resolved.

Src/LexText/Interlinear/InterlinVc.cs line 1280 at r3 (raw file):

							AddTssDirForWs(vwenv, defUserWs);
							vwenv.AddString(m_tssDefaultSpace);
							vwenv.AddString(tssMediaLabel);

Could we do this by adding a single format string so we don't need resources that include and don't include spaces?

@aror92
Copy link
Copy Markdown
Contributor Author

aror92 commented Mar 5, 2026

Could we do this by adding a single format string so we don't need resources that include and don't include spaces?

I'm not sure I understand the idea & scope you have in mind. I removed most of the new trailing space resources. The only remaining new one is ksMedia_; it's used in AddFreeformComment, since all labels there use the resource with space. But there are a lot of places throughout InterlinearVc where we could replace use of the resources that include spaces with a format string. A future refactor to implement that should allow us to remove more of the resources with space.

@aror92 aror92 merged commit cb8af5f into release/9.3 Mar 5, 2026
4 of 5 checks passed
@aror92 aror92 deleted the LT-22314-interlinear-medialine branch March 5, 2026 13:11
papeh pushed a commit that referenced this pull request Mar 9, 2026
@aror92 @mark-sil @papeh
LT-22314: Create new media line for interlinear display (#720)
e48e9a3 
* Create new media line for interlinear display

Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Displays begin and end time offsets and speaker name
for each audio clip.

Handles bidi and display in multiple writing systems.

Displays a no media message instead of the audio play
button/info if there is no media file.

---------

Co-authored-by: mark-sil <[email protected]>
(cherry picked from commit cb8af5f)
jasonleenaylor pushed a commit that referenced this pull request Mar 13, 2026
@aror92 @mark-sil @jasonleenaylor
LT-22314: Create new media line for interlinear display (#720)
a295077 
* Create new media line for interlinear display

Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Displays begin and end time offsets and speaker name
for each audio clip.

Handles bidi and display in multiple writing systems.

Displays a no media message instead of the audio play
button/info if there is no media file.

---------

Co-authored-by: mark-sil <[email protected]>
(cherry picked from commit cb8af5f)
(cherry picked from commit e48e9a3)
jasonleenaylor pushed a commit that referenced this pull request Mar 13, 2026
@aror92 @mark-sil @jasonleenaylor
LT-22314: Create new media line for interlinear display (#720)
2e1ba9c 
* Create new media line for interlinear display

Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Displays begin and end time offsets and speaker name
for each audio clip.

Handles bidi and display in multiple writing systems.

Displays a no media message instead of the audio play
button/info if there is no media file.

---------

Co-authored-by: mark-sil <[email protected]>
(cherry picked from commit cb8af5f)
(cherry picked from commit e48e9a3)
jasonleenaylor pushed a commit that referenced this pull request Mar 13, 2026
@aror92 @mark-sil @jasonleenaylor
LT-22314: Create new media line for interlinear display (#720)
e0bd89c 
* Create new media line for interlinear display

Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Displays begin and end time offsets and speaker name
for each audio clip.

Handles bidi and display in multiple writing systems.

Displays a no media message instead of the audio play
button/info if there is no media file.

---------

Co-authored-by: mark-sil <[email protected]>
(cherry picked from commit cb8af5f)
(cherry picked from commit e48e9a3)
jasonleenaylor pushed a commit that referenced this pull request Mar 15, 2026
@aror92 @mark-sil @jasonleenaylor
LT-22314: Create new media line for interlinear display (#720)
f20800d 
* Create new media line for interlinear display

Includes support for playing audio file segments

This supports the following workflows:
1. Clicking the play button plays the segment.
2. Clicking the same play button, while the segment is still
playing, will stop playing.
3. Clicking a different play button, while a segment is still
playing, will stop playing the current segment and start playing
the new one.
4. While the audio is playing the user can continue to work in
the gui. If the user does something that disposes the
InterlinDocForAnalysis, then the audio will stop.

Displays begin and end time offsets and speaker name
for each audio clip.

Handles bidi and display in multiple writing systems.

Displays a no media message instead of the audio play
button/info if there is no media file.

---------

Co-authored-by: mark-sil <[email protected]>
(cherry picked from commit cb8af5f)
(cherry picked from commit e48e9a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aror92 @jasonleenaylor