Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: slackhq/SlackTextViewController
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: siburb/SlackTextViewController
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 1, 2015

  1. Configuration menu
    Copy the full SHA
    2a6693f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7027f2 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2015

  1. Merge commit 'd0a1dee74320c6d867bbed2504f9503861ef5436'

    * commit 'd0a1dee74320c6d867bbed2504f9503861ef5436': (28 commits)
      Update README URLs based on HTTP redirects
      Fixes `shouldScrollToBottomAfterKeyboardShows`, not being performed right, specially in inverted mode. Fixes #296
      Scrolls to top when hitting the status bar. Fixes #271
      Fixes the content inset being off when inverted mode was disabled. Fixes #195 Also, avoids having to interact with edgesForExtendedLayout to adjust the top and bottom insets. No need.
      Uses 'fontName' instead of 'familyName' property, to maintain the font type (regular, bold, italic) Fixes #305
      Add do nothing if key for persistence is nil
      Fix case of nil that persistence text key
      Fixes warning on iOS 8 and 9
      Adds 'UITextInputCurrentInputModeDidChangeNotification'  notification. Related to #210
      Fixes SLKKeyboard notifications not being fired accordantly Fixes #290
      Skips the keyboard notifications if there is actually no first responder to relay on Fixes #297
      Uses UIAlertController for iOS 8 and above
      Documentation sanity
      Version bump (1.7.2)
      Fix rightButton margin is not correctly set when autoHideRightButton = NO
      share SlackTextViewController scheme
      Fixes the `contentSize` to never be higher than the `bounds` when there is only 1 line of content. This helps avoiding unnecessary scrolling in the text view when setting for larger and smaller font sizes.
      Update README.md
      Update README.md
      Version bump (1.7.1)
      ...
    siburb committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    64f32b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2016

  1. Merge commit '79c27cf47528097a72a6146c5e982df93f9cd51a'

    * commit '79c27cf47528097a72a6146c5e982df93f9cd51a': (45 commits)
      Version bump (1.9)
      Even if the newSuperview is valid on iOS 9, this is not enough to move the keyboard when dragging the text input
      Removes iOS 9 keyboard detection code
      Removes any usage of the deprecated isLoupeVisible falg
      Makes sure not to scroll if the content size is smaller than its bounds
      Re-orders the sequence where the keyboard status was being updated. Fixes illogical keyboard states and missing notifications from being fired. Fixes #327
      Also fixes the link
      Fixed typos
      Tweaked documentation
      Typo
      Deprecated 'isLoupeVisible' and added more documentation
      Tweaking the sample project's layout for better looking auto-completion cells
      Skip any panning gesture handling if the keyboard's view has been detected.
      Comments out any private API usage
      Fixes crash when calling unrecognised selectors internally in the UITextViewDelegate method implementation, when using other subclasses of UITextView. Fixes #339 Also, exposes overridden UITextViewDelegate method using UITextView return type.
      Fixes the panning gesture when there is a bottom margin needed too
      Setts a bottom margin when the text input bar doesn't require to be adjusted because of the keyboard
      Fixes UITabBar support when the edgesForExtendedLayout is .None Allows future support of other view controller containment with bottom bar adjustment.
      Fixes the text input showing beneath the tab bar. Fixes #340
      Updates sample project's icon for iPad Pro
      ...
    
    # Conflicts:
    #	Source/SLKTextViewController.m
    siburb committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    4e33b78 View commit details
    Browse the repository at this point in the history
Loading