For #46920, custom CA certs for file transfer#171
Merged
Conversation
jfboismenu
commented
Mar 21, 2018
| Build urllib2 opener with appropriate proxy handler. | ||
| """ | ||
| handlers = [] | ||
| if self.__ca_certs and not NO_SSL_VALIDATION: |
Contributor
Author
There was a problem hiding this comment.
This fix is only applied if __ca_certs is set, which makes it very safe as it doesn't impact any other usage of the API. The build_opener is strictly used for uploads/downloads.
In other words, if this fix has a bug somewhere inside it on certain conditions, it will only fail for people who are using SHOTGUN_API_CACERTS, who already can't download and upload at the moment anyway.
brandonvfx
approved these changes
Mar 21, 2018
brandonvfx
left a comment
brandonvfx
left a comment
Contributor
There was a problem hiding this comment.
I think it looks good.
Contributor
Author
|
All this has been tested with proxies and python 2.6 |
This was referenced Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to upload and download files from local Shotgun sites using HTTPS with a custom certificate authority certificate.