Support span tags in rendering description#1
Merged
michaelginalick merged 1 commit intomasterfrom Feb 24, 2023
Merged
Conversation
Author
|
PR to opensource library contentstack#9 |
sypher7
approved these changes
Feb 23, 2023
wenga86
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copy/pasting text into the description field on contentstack. Contentstack will wrap the text in a span tag. This is fine except the open source library doesn't support span tags. As a result, during the write back process the description field is set to an empty string and the entry will fail to import due to validation errors.
This fork of the library will add support for spans. Note I will also open a PR on the open source repo, and reference it in the contenthub rails app as we will need to use this fork until the PR is merged.