Skip to content

fix: move devDependencies where they belong to#155

Merged
shellscape merged 1 commit into
shellscape:masterfrom
XhmikosR:xmr/deps
Mar 7, 2026
Merged

fix: move devDependencies where they belong to#155
shellscape merged 1 commit into
shellscape:masterfrom
XhmikosR:xmr/deps

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

After #149, husky and @dot/versioner were wrongfully included in dependencies.

/CC @shellscape

@shellscape shellscape merged commit 6cc6e7d into shellscape:master Mar 7, 2026
6 checks passed
@shellscape

Copy link
Copy Markdown
Owner

thanks!

Will get this published later on todayish.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

@shellscape: friendly ping in case you forgot cutting a new patch release :)

@XhmikosR

XhmikosR commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@shellscape friendly ping to cut a new patch version :)

@XhmikosR

Copy link
Copy Markdown
Contributor Author

@shellscape can you please release v7.0.2 with this fix?

@shellscape

Copy link
Copy Markdown
Owner

@XhmikosR 8.0.0 is up, bumped minimum node version

@XhmikosR

Copy link
Copy Markdown
Contributor Author

That's unfortunate... This patch could have landed as 7.0.2. Now we are forced to drop support for Node.js < 22 too...

@shellscape

Copy link
Copy Markdown
Owner

@XhmikosR Node < 22 is out of LTS and unsupported as of last month. Which project is of concern here?

@shellscape

Copy link
Copy Markdown
Owner
→ npm info postcss-values-parser dist-tags
{ next: '3.0.0-beta.4', latest: '8.0.0', last: '7.0.1' }

I pushed a new tag and published 7.0.1 for you. Still curious what project you're on that hasn't dropped v20. It wont be getting any security updates so I'd encourage you to move quickly. Major version numbers are free :)

@XhmikosR

Copy link
Copy Markdown
Contributor Author

I know Node.js 20 is not supported anymore but this patch was a patch fix for version 7.0.0.

I'm in the process of migrating the dependents' packages to ESM and due to time, I started all the patches aiming for Node.js 20.19. It'd be a PITA to go back and change all 20+ repositories again. Directly, only detective-postcss depends on postcss-values-parser.

Thanks for the patch release!

@shellscape

Copy link
Copy Markdown
Owner

Interesting, thanks for sharing. No problem at all.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

BTW I'm having trouble upgrading to v7 in detective-postcss, I'll try to have a closer look later and maybe open a new issue since I might be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants