Skip to content

Specify "token" argument name in example code block in README.md.#420

Merged
lavabyrd merged 1 commit into
slackapi:masterfrom
mcbridem:master
May 15, 2019
Merged

Specify "token" argument name in example code block in README.md.#420
lavabyrd merged 1 commit into
slackapi:masterfrom
mcbridem:master

Conversation

@mcbridem

Copy link
Copy Markdown

Otherwise there seems to be a consistent exception being thrown:

TypeError: init() takes 1 positional argument but 2 were given

Otherwise there seems to be a consistent exception being thrown:
> TypeError: __init__() takes 1 positional argument but 2 were given
@CLAassistant

CLAassistant commented May 15, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented May 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   56.94%   56.94%           
=======================================
  Files           6        6           
  Lines         734      734           
  Branches       42       42           
=======================================
  Hits          418      418           
  Misses        307      307           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc756d8...a57faf3. Read the comment docs.

@lavabyrd lavabyrd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this @mcbridem !

@lavabyrd lavabyrd self-assigned this May 15, 2019
@lavabyrd lavabyrd merged commit 45c1930 into slackapi:master May 15, 2019
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
…lackapi#420)

Otherwise there seems to be a consistent exception being thrown:
> TypeError: __init__() takes 1 positional argument but 2 were given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants