Conversation
Switch to the glob module to do shell globbing. Fixes a bug in `cp()` where hidden files were not copied recursively.
| } | ||
|
|
||
| sources = common.expand(sources); | ||
| sources = common.expand(sources, {dot: true}); |
Contributor
There was a problem hiding this comment.
Isn't this done in common.wrap?
Member
Author
There was a problem hiding this comment.
This is still necessary because this is how we turn a directory into a list of its contents. We can probably do an alternative approach, though
Contributor
|
LGTM. I'm going to try to simplify |
Contributor
|
Also, @nfischer, thank so much for doing this. |
ariporad
added a commit
that referenced
this pull request
Feb 16, 2016
feat(glob): use glob module for globbing
Member
Author
|
I agree, we probably can and should trim down on ls's code a bit |
This was referenced Feb 16, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to the glob module to do shell globbing. Fixes a bug in
cp()wherehidden files were not copied recursively.
Replaces #275, fixes #225. This is a less-aggressive version of #275 (doesn't modify
ls()nearly as much). We should probably add some more glob-related tests though, likefile?.txtand things of that sort.I wrote this up because this will fix one of the bugs I found when writing the
ShellStringrefactor for free.For what it's worth, this does hurt performance slightly (it takes 16 seconds on average to run
npm testinstead of 15 seconds), but not by very much. We might be able to get that performance back some other way.Closes #275, #225.