Run on Rust stable - #95
Conversation
8cbd44a to
17ced83
Compare
|
Reviewed 13 of 14 files at r1. .travis.yml, line 8 [r1] (raw file): src/atom/mod.rs, line 91 [r1] (raw file): src/atom/mod.rs, line 234 [r1] (raw file): Comments from the review on Reviewable.io |
|
Review status: 10 of 14 files reviewed at latest revision, 3 unresolved discussions, some commit checks pending. .travis.yml, line 8 [r1] (raw file): src/atom/mod.rs, line 234 [r1] (raw file): Comments from the review on Reviewable.io |
|
Review status: 10 of 14 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. src/atom/mod.rs, line 91 [r1] (raw file):
Comments from the review on Reviewable.io |
|
☔ The latest upstream changes (presumably #96) made this pull request unmergeable. Please resolve the merge conflicts. |
We only need 2 bits to store the tag (which is 0b_00, 0b_01, or 0b_10). This will enable using `Box::new` instead of `heap::allocate`. @gw, was there another reason to have it at 16?
…eature flag. Without `--features unstable`: * `Atom` is 16 bytes instead of 8. (It has a drop flag.) * `ns!` and `atom!` are giant generated macros instead of plugins, and so may increase compile time.
That way, a deprecation warning won’t break dependants.
It’s not necessary, but makes it clearer to readers what’s going on.
|
Reviewed 1 of 14 files at r1. Comments from the review on Reviewable.io |
|
@SimonSapin looks good to me. |
|
@bors-servo r=glennw |
|
📌 Commit f7fd964 has been approved by |
Run on Rust stable Without `--features unstable`: * `Atom` is 16 bytes instead of 8. (It has a drop flag.) * `ns!` and `atom!` are giant generated macros instead of plugins, and so may increase compile times. r? @glennw, particularly c4fa256. Needed for servo/html5ever#53 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/95) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Without
--features unstable:Atomis 16 bytes instead of 8. (It has a drop flag.)ns!andatom!are giant generated macros instead of plugins, and so may increase compile times.r? @glennw, particularly c4fa256.
Needed for servo/html5ever#53