Add "before" and "after" atoms. - #141
Conversation
|
r? @SimonSapin |
|
Version bump! |
|
Looks good. Can you squash the two commits into one? Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
|
I disagree with squashing, because we wouldn't be able to tell from the commit message which commit the version bump happened. |
|
Fine by me. @bors-servo: r+ |
|
📌 Commit e6377bb has been approved by |
Add "before" and "after" atoms. Needed for servo/servo#9567 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/141) <!-- Reviewable:end -->
|
@bors-servo: r- force |
|
I'd wait to land this until the approach taken in servo/servo#9567 is decided. There might be a chance this is not needed. Re: squashing, I don't mind doing it. I think it's fine since it's a one-commit release. |
|
|
|
OK, though the cost for adding new static atoms is pretty small, and we're quite likely to want before and after at some point. |
e6377bb to
ee3ff8e
Compare
|
@asajeffrey: Merge it if you want then, I personally won't add unneeded atoms, but I agree these are likely to be desirable at some point :) |
|
We can leave it open for the moment, and wait for the dust to settle on servo/servo#9567. |
|
☔ The latest upstream changes (presumably #146) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing this since servo/servo#9567 implementation didn't finally need this. |
Needed for servo/servo#9567