Skip to content

Added "*" atom. - #115

Merged
bors-servo merged 1 commit into
servo:masterfrom
asajeffrey:add_star
Oct 26, 2015
Merged

Added "*" atom.#115
bors-servo merged 1 commit into
servo:masterfrom
asajeffrey:add_star

Conversation

@asajeffrey

@asajeffrey asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown

Added "*" to the list of constant atoms. It's used in getElementsByTagName and getElementsByTagNameNS in https://github.com/asajeffrey/servo/tree/versioned_dom.

Review on Reviewable

@metajack

metajack commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

@bors-servo r+

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

@bors-servo

bors-servo commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

📌 Commit ca6af9c has been approved by metajack

@bors-servo

bors-servo commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

⌛ Testing commit ca6af9c with merge ab176cd...

bors-servo pushed a commit that referenced this pull request Oct 26, 2015
bors-servo
Auto merge of #115 - asajeffrey:add_star, r=metajack
ab176cd 
Added "*" atom.

Added "*" to the list of constant atoms. It's used in getElementsByTagName and getElementsByTagNameNS in https://github.com/asajeffrey/servo/tree/versioned_dom.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/115)
<!-- Reviewable:end -->
@bors-servo

bors-servo commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

☀️ Test successful - travis

@bors-servo
bors-servo merged commit ca6af9c into servo:master Oct 26, 2015
@asajeffrey

asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown
Author

Do we need to bump the versions, as in c83d753?

@jdm

jdm commented Oct 26, 2015

Copy link
Copy Markdown
Member

Yes.

@metajack

metajack commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Just, bump the version, and when the PR lands we tag and upload to crates.io. I can walk you through that if you'd like to do it once a version bump PR lands.

@asajeffrey

asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown
Author

OK, should I do the version bump? Do I just submit a PR as per usual?

@asajeffrey
asajeffrey deleted the add_star branch October 26, 2015 15:45
@metajack

metajack commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Yep. It uses semver, and since this is backwards compat, just increment the final number by one.

@asajeffrey

asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown
Author

OK. Do I need to also do a PR on servo to bump the version number it uses?

@metajack

metajack commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Yes. There may be other packages that also need a version bump, but those will get figured out. The servo one is the important one.

@asajeffrey

asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown
Author

Will do.

@asajeffrey asajeffrey mentioned this pull request Oct 26, 2015
Merged
@asajeffrey

asajeffrey commented Oct 26, 2015

Copy link
Copy Markdown
Author

Done. #116

bors-servo pushed a commit that referenced this pull request Oct 26, 2015
bors-servo
Auto merge of #116 - asajeffrey:version_bump, r=metajack
e9f4c63 
Version bump.

Version bump for #115.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/116)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@asajeffrey @metajack @bors-servo @jdm