Make example code better describe its failure for newbies#68
Merged
Yepoleb merged 1 commit intoserverstf:masterfrom Sep 16, 2018
Merged
Make example code better describe its failure for newbies#68Yepoleb merged 1 commit intoserverstf:masterfrom
Yepoleb merged 1 commit intoserverstf:masterfrom
Conversation
Use python3 print everywhere.
Member
|
Good idea, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code for querying the master server in README.md assumes only the master server can timeout, which makes people think something is wrong with the master server (or the library), while iterating over game servers (many of which will be unreachable for some reason).
An example of an issue caused by this lack of error checking here: #63
Changes:
printeverywhere.Note: I have just modified the README.md file. The Travis checks were already failing previously.