Skip to content

Add action file#81

Merged
DavideViolante merged 1 commit into
serverless:nextfrom
o-az:action-yml-file
May 30, 2023
Merged

Add action file#81
DavideViolante merged 1 commit into
serverless:nextfrom
o-az:action-yml-file

Conversation

@o-az

@o-az o-az commented May 4, 2023

Copy link
Copy Markdown
Contributor

Followed this guide: https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

The motivation behind this PR is to provide support in editors and prevent eroror / squiggly red line when using this action:

CleanShot 2023-05-04 at 05 20 14@2x
^ This error is due to missing action.yml. It still lets you use the action but doesn't provide you with any hints/autocomplete.

The action.yml file allows the official GitHub VSCode extension to provide descriptions and autocomplete when using the action. For example, here's the autocomplete support for actions/checkout@v3:

CleanShot 2023-05-04 at 05 33 08@2x

Is there a way an admin of this repo could create a next branch to merge this into instead of merging to master first? This is so I can further verify the types and autocomplete support (in addition to the testing I've done).
Once merged to next, I use the action like this:

# ...
uses: serverless/github-action@next
# ...

Then once all is good, I report back and request merge to master

@DavideViolante DavideViolante changed the base branch from master to next May 30, 2023 08:30
@DavideViolante DavideViolante changed the title add action file Add action file May 30, 2023
@DavideViolante DavideViolante merged commit 3ca0183 into serverless:next May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants