Skip to content

Change the behavior of string to bool conversion#138

Merged
disktnk merged 2 commits into
sensorbee:masterfrom
nobu-k:string-bool-conv
May 2, 2017
Merged

Change the behavior of string to bool conversion#138
disktnk merged 2 commits into
sensorbee:masterfrom
nobu-k:string-bool-conv

Conversation

@nobu-k
Copy link
Copy Markdown
Member

@nobu-k nobu-k commented May 2, 2017

This is a breaking change as described in #84 .

Fixes #84 and #134

@nobu-k
Copy link
Copy Markdown
Member Author

nobu-k commented May 2, 2017

This test relies on testing.T.Run, which was introduced in Go 1.7. As we discussed in #119, we'll only support Go 1.8 or later after the next version.

@nobu-k nobu-k mentioned this pull request May 2, 2017
Merged
@disktnk disktnk merged commit 9c20210 into sensorbee:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nobu-k @disktnk