Minor fixes

RamseyK · RamseyK · commit 50165ab092ee · 2020-12-28T15:33:21.000-05:00
diff --git a/src/HTTPMessage.cpp b/src/HTTPMessage.cpp
@@ -150,6 +150,7 @@ std::string HTTPMessage::getStrElement(char delim) {
 
 	// Grab the std::string from the byte buffer up to the delimiter
 	char *str = new char[size];
+	bzero(str, size);
 	getBytes((byte*)str, size);
 	str[size - 1] = 0x00; // NULL termination
 	ret.assign(str);
diff --git a/src/HTTPMessage.h b/src/HTTPMessage.h
@@ -28,7 +28,7 @@
 // Constants
 #define HTTP_VERSION_10 "HTTP/1.0"
 #define HTTP_VERSION_11 "HTTP/1.1"
-#define DEFAULT_HTTP_VERSION "HTTP/1.1"
+#define DEFAULT_HTTP_VERSION HTTP_VERSION_11
 #define NUM_METHODS 9
 
 // HTTP Methods (Requests)
diff --git a/src/HTTPServer.cpp b/src/HTTPServer.cpp
@@ -44,7 +44,7 @@ HTTPServer::HTTPServer(std::vector<std::string> vhost_aliases, int port, std::st
 	hostList.push_back(resHost);
 
 	// Always serve up localhost/127.0.0.1 (which is why we only added one ResourceHost to hostList above)
-	char tmpstr[128];
+	char tmpstr[128] = {0};
 	sprintf(tmpstr, "localhost:%i", listenPort);
 	vhosts.insert(std::pair<std::string, ResourceHost*>(std::string(tmpstr).c_str(), resHost));
 	sprintf(tmpstr, "127.0.0.1:%i", listenPort);
@@ -591,6 +591,7 @@ void HTTPServer::handleTrace(Client* cl, HTTPRequest *req) {
 	// Get a byte array representation of the request
 	unsigned int len = req->size();
 	byte* buf = new byte[len];
+	bzero(buf, len);
 	req->setReadPos(0); // Set the read position at the beginning since the request has already been read to the end
 	req->getBytes(buf, len);
 
@@ -649,7 +650,7 @@ void HTTPServer::sendResponse(Client* cl, HTTPResponse* resp, bool disconnect) {
 
 	// Time stamp the response with the Date header
 	std::string tstr;
-	char tbuf[36];
+	char tbuf[36] = {0};
 	time_t rawtime;
 	struct tm* ptm;
 	time(&rawtime);
