Skip to content

Add complex header support - #53

Merged
demoore merged 2 commits into
masterfrom
add-complex-header-support
Nov 7, 2022
Merged

demoore merged 2 commits into
masterfrom
add-complex-header-support

Conversation

@demoore

@demoore demoore commented Nov 7, 2022

Copy link
Copy Markdown
Member

Description

This change updates Headers from being a HashMap of <String, String> to the more generic <String, Object>

Motivation and Context

Sometimes we may want to additional information to a target ESP through the headers field to change how it will behave.

How Has This Been Tested?

Manually and via the test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sometimes we may want to additional information to a target ESP through the
`headers` field. This change updates Headers from being a HashMap of <String,
String> to the more generic <String, Object>
@demoore demoore self-assigned this Nov 7, 2022
@demoore
demoore requested a review from a team as a code owner November 7, 2022 22:05
@turnerdev

Copy link
Copy Markdown

lgtm

@demoore
demoore merged commit 4f7c377 into master Nov 7, 2022
@demoore
demoore deleted the add-complex-header-support branch November 7, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants