Repository navigation
Add preheader and amp_html support - #51
Merged
Merged
Conversation
Version 5 is no longer supported; bumping up to version 8.
With newer versions of Java we need to use Mockito >=2.18.0
New optional fields are supported allowing the client to get and set the preheader and amp_html fields on a TemplateVersionDetails object. The amp_html field is the AMP-enabled version of an email; in cases where AMP is not supported the email will fall back to either the HTML or text version of the template.
|
The |
turnerdev
approved these changes
Jul 7, 2022
The resend test was failing sometimes because the sendlog wouldn't exist when the test tried to resend the email. Adding a 5 second wait is hack-y but effective until we can remove our dependency on the live production API.
dtlinley-dyspatch
force-pushed
the
add-preheader-support
branch
from
July 7, 2022 20:23
61f13c8 to
fec86a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for getting and setting the optional
preheaderandamp_htmlfields on Template Version Details.Also includes necessary updates to libraries to get the build working again, as well as minimal development instructions.
Types of changes
Checklist: