Fixes version ambiguity in gemspec#112
Fixes version ambiguity in gemspec#112thinkingserious merged 1 commit intosendgrid:masterfrom cmckni3:master
Conversation
|
I think I know why the tests are failing for you, I need to update this code to no longer pull the environment variable as that variable does not get pulled for those outside of the sendgrid organization. I'll fix that and get this merged. In the mean time, could you please sign our CLA so that I can merge your changes? Thanks! |
|
Good deal. I was wondering why it was fine locally but not on Travis. Sure, I can sign the CLA. |
|
Could you please update your branch to the latest release? https://github.com/sendgrid/sendgrid-ruby/releases/tag/v4.0.6 Thanks! |
|
@thinkingserious Done. Waiting for Travis |
|
@thinkingserious thoughts? |
|
This one is in our queue to review and merge. Apologies for the delay, Hacktoberfest went really well and we have a unusual amount of issues and pull requests to get done currently. |
|
No problem. Was just making sure it wasn't forgotten. |
|
Rebased my branch |
|
Hi @cmckni3, Looks we need one more rebase to get this one out the door. Thanks! |
|
Rebased |
|
Update: Done |
|
@thinkingserious Glad to help out! I filled out the form 😃 |
|
Awesome, thank you! We hope you enjoy the swag :) |
|
Forgot to mention, the swag is awesome. Thanks again! |
|
Thanks for the follow up! If you get a PR accepted this month, there is some new exclusive swag for you ;) With Best Regards, Elmer |
|
Awesome! Thanks for the heads up! |
No description provided.