Skip to content

Fixes version ambiguity in gemspec#112

Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
cmckni3:master
Apr 11, 2017
Merged

Fixes version ambiguity in gemspec#112
thinkingserious merged 1 commit intosendgrid:masterfrom
cmckni3:master

Conversation

@cmckni3
Copy link
Copy Markdown
Contributor

@cmckni3 cmckni3 commented Oct 18, 2016

No description provided.

@cmckni3 cmckni3 closed this Oct 18, 2016
@cmckni3 cmckni3 reopened this Oct 18, 2016
@thinkingserious
Copy link
Copy Markdown
Contributor

@cmckni3,

I think I know why the tests are failing for you, I need to update this code to no longer pull the environment variable as that variable does not get pulled for those outside of the sendgrid organization. I'll fix that and get this merged.

In the mean time, could you please sign our CLA so that I can merge your changes? Thanks!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla needed labels Oct 18, 2016
@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Oct 18, 2016

Good deal. I was wondering why it was fine locally but not on Travis.

Sure, I can sign the CLA.

@thinkingserious thinkingserious added status: cla signed status: work in progress Twilio or the community is in the process of implementing and removed status: cla needed labels Oct 18, 2016
@thinkingserious
Copy link
Copy Markdown
Contributor

@cmckni3,

Could you please update your branch to the latest release? https://github.com/sendgrid/sendgrid-ruby/releases/tag/v4.0.6

Thanks!

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Oct 18, 2016

@thinkingserious Done. Waiting for Travis

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Nov 11, 2016

@thinkingserious thoughts?

@thinkingserious
Copy link
Copy Markdown
Contributor

@cmckni3,

This one is in our queue to review and merge.

Apologies for the delay, Hacktoberfest went really well and we have a unusual amount of issues and pull requests to get done currently.

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Nov 14, 2016

No problem. Was just making sure it wasn't forgotten.

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Feb 7, 2017

Rebased my branch

@thinkingserious
Copy link
Copy Markdown
Contributor

Hi @cmckni3,

Looks we need one more rebase to get this one out the door. Thanks!

@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Apr 11, 2017

CLA assistant check
All committers have signed the CLA.

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Apr 11, 2017

Rebased

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Apr 11, 2017

Do I need to sign the CLA again?

Update: Done

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @cmckni3,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 287eca1 into sendgrid:master Apr 11, 2017
@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Apr 11, 2017

@thinkingserious Glad to help out!

I filled out the form 😃

@thinkingserious
Copy link
Copy Markdown
Contributor

Awesome, thank you! We hope you enjoy the swag :)

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Oct 2, 2017

Forgot to mention, the swag is awesome. Thanks again!

@thinkingserious
Copy link
Copy Markdown
Contributor

Thanks for the follow up!

If you get a PR accepted this month, there is some new exclusive swag for you ;)

With Best Regards,

Elmer

@cmckni3
Copy link
Copy Markdown
Contributor Author

cmckni3 commented Oct 2, 2017

Awesome! Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants