Skip to content

Fixed a broken link for use cases#703

Closed
shendrekbharath wants to merge 1 commit into
sendgrid:masterfrom
shendrekbharath:master
Closed

Fixed a broken link for use cases#703
shendrekbharath wants to merge 1 commit into
sendgrid:masterfrom
shendrekbharath:master

Conversation

@shendrekbharath

@shendrekbharath shendrekbharath commented Oct 21, 2018 •
edited by misterdorm
Loading

Copy link
Copy Markdown

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • [#] I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

The below USE_CASES link under Changelog.md was broken, fixed the same.

Error: https://github.com/sendgrid/sendgrid-python/blob/master/USE_CASES.md on line 228 is unreachable.

Updated Link
https://github.com/sendgrid/sendgrid-python/tree/master/use_cases

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 21, 2018
@SendGridDX

SendGridDX commented Oct 21, 2018 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Oct 21, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b68316...c0efe70. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 30, 2018
misterdorm
misterdorm requested changes Oct 30, 2018
View reviewed changes

@misterdorm misterdorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please rebase this against the v4 branch? Thanks!

@thinkingserious thinkingserious added type: docs update documentation change not affecting the code status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 31, 2018
@thinkingserious

thinkingserious commented Nov 2, 2018

Copy link
Copy Markdown
Contributor

Hello @shendrekbharath,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

shendrekbharath
shendrekbharath commented Dec 4, 2018
View reviewed changes

@shendrekbharath shendrekbharath left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to the changes

@misterdorm

misterdorm commented Dec 5, 2018

Copy link
Copy Markdown
Contributor

@shendrekbharath Sorry. We'll need the PR to be against the v4 branch, not master. You can close this PR and create a new one if that's easier than rebasing. Thanks!

@thinkingserious

thinkingserious commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Hello @shendrekbharath,

Are you still interested in submitting this one? If so, please rebase against the v4 branch or please create a new PR against the v4 branch.

Thanks!

With Best Regards,

Elmer

@shendrekbharath

shendrekbharath commented Jan 25, 2019

Copy link
Copy Markdown
Author

Hi Elmer,
Thanks for reminding me on this!

I have created a new PR for v4 branch.

#754

Rgrds,
Bharath

@thinkingserious

thinkingserious commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@misterdorm misterdorm misterdorm requested changes
+1 more reviewer
@42B 42B 42B approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shendrekbharath @SendGridDX @thinkingserious @misterdorm @42B