Skip to content

master #517

Closed
nishantmadu wants to merge 213 commits into
hello_world_testfrom
master
Closed

master #517
nishantmadu wants to merge 213 commits into
hello_world_testfrom
master

Conversation

@nishantmadu

Copy link
Copy Markdown

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

thinkingserious and others added 30 commits June 16, 2017 16:06
 - Add before repo description
 - Bump down breaking change announcement
 - Add in "Announcements"
Bold "New", remove breaking changes announcement.
Deploy automatically after successful build
Remove Python 3.2, 3.3.  Load dependencies from requirements.txt.
Wait until we download and install Prism to start running it.
Nothing says your virtualenv is under venv/ or that you're using one at all.
Everything but python 2.6 uses unittest discover, so might as well make it easy to change.
See gabrielkrell/sendgrid-python-docker for commit history.

Dockerfile downloads python versions, Prism, tox, default (latest at build time) SendGrid libs.  Maintains symlinks for easy use.
Add SendGrid footer, headers.  Clean up examples, add actual code.
Be more clear about how to use old versions.
Graphical tweaks, mostly.  Single space after sentences.
Turns out GitHub's syntax highlighting for bash sessions sucks, though.  They pull from a documented repo, so one to-do is contribute to this in personal time.
Dockerfile
 - Pin to specific Ubuntu
Readme:
 - Mention preinstalled Pythons
 - Link to releases page
Entrypoint:
 - Tidy welcome text
 - Explain mock/no-mock mode
 - Remove "passthrough"
 - Tidy exit text
New README.md because it shows up in Docker Hub.  Moved old contents to USAGE.md.
Consistency with other readmes
Linking to the Docker Hub page for now, even though USAGE.md is better.
Add docker hype to readme preheader, "dev env" section of contributing.
Add backfilled tag numbers, typo fix
Update docker readme versions
Change example code for "retrieve all campaigns" to actually get more than one (use the default parameters of limit 10, no offset)
Change usage example "retrieve all campaigns"
Matt Bernier and others added 24 commits October 28, 2017 11:20
Shuffle docs around to fit the new Mail helper structure.  Hopefully I didn't miss anything; due to the amount of code getting moved around. I'll check the diff against master and then revert if needed.
Clear up some straggling stray whitespace, etc.
Put TrackingSettings in the right place.
I hate moving around big chunks of code like this; I wish git was more intelligent moving things between files.
Updated date-range in LICENSE file
- os import is not used
Typo fix: Changed Sengrid to Sendgrid on 2 instances (both on line 58…
Documented the new error handling functionality from python-http-client
removing unsed import in registry
Error-checking in Mail helper/ASM
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mbernier mbernier added the spam label Oct 31, 2017
@mbernier

Copy link
Copy Markdown
Contributor

This PR doesn't seem to provide a material change to the code base, it looks like a bunch of merges. If you disagree, please reply and let us know. Thanks!

@mbernier mbernier closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.