Skip to content

Moved mail helper classes into separate files#472

Merged
mbernier merged 1 commit into
sendgrid:masterfrom
runz0rd:master
Oct 28, 2017
Merged

Moved mail helper classes into separate files#472
mbernier merged 1 commit into
sendgrid:masterfrom
runz0rd:master

Conversation

@runz0rd

@runz0rd runz0rd commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

For #459

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX

SendGridDX commented Oct 28, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 28, 2017
@codecov-io

codecov-io commented Oct 28, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #472 into master will increase coverage by 0.39%.
The diff coverage is 86.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   82.41%   82.81%   +0.39%     
==========================================
  Files           9       30      +21     
  Lines        1001     1024      +23     
  Branches      160      160              
==========================================
+ Hits          825      848      +23     
  Misses         86       86              
  Partials       90       90
Impacted Files Coverage Δ
sendgrid/helpers/mail/__init__.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/mail.py 97.51% <100%> (+9.24%) ⬆️
sendgrid/helpers/mail/asm.py 73.91% <73.91%> (ø)
sendgrid/helpers/mail/ganalytics.py 79.66% <79.66%> (ø)
sendgrid/helpers/mail/subscription_tracking.py 80.48% <80.48%> (ø)
sendgrid/helpers/mail/footer_settings.py 81.25% <81.25%> (ø)
sendgrid/helpers/mail/spam_check.py 81.25% <81.25%> (ø)
sendgrid/helpers/mail/category.py 81.81% <81.81%> (ø)
sendgrid/helpers/mail/click_tracking.py 82.6% <82.6%> (ø)
sendgrid/helpers/mail/content.py 82.6% <82.6%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef24b14...d0005c7. Read the comment docs.

@mbernier

mbernier commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

awwwww yeah!

@mbernier
mbernier merged commit 086b3c7 into sendgrid:master Oct 28, 2017
@thinkingserious

thinkingserious commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

Hello @runz0rd,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@gabrielkrell gabrielkrell mentioned this pull request Oct 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@runz0rd @SendGridDX @codecov-io @mbernier @thinkingserious