Add unit tests for app.py#441
Conversation
thinkingserious
added
the
status: code review request
|
|
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 82.38% 82.81% +0.43%
==========================================
Files 9 9
Lines 999 1001 +2
Branches 160 160
==========================================
+ Hits 823 829 +6
+ Misses 86 82 -4
Partials 90 90
Continue to review full report at Codecov.
|
mbernier
left a comment
mbernier
left a comment
There was a problem hiding this comment.
The tests ran and passed locally for me.
| @@ -0,0 +1,35 @@ | |||
| from unittest import mock | |||
| from unittest.mock import MagicMock | |||
There was a problem hiding this comment.
For Python 2.6, 2.7 builds to pass, we have to add a little bit of trickery:
try:
import unittest2 as unittest
except ImportError:
import unittest
and for mock, it looks like we can borrow some advice from this guy:
try:
from mock import patch, mock_open
except ImportError:
from unittest.mock import patch, mock_open
Can you please make these two changes? I am hoping the build will pass once this is done!
|
@cbonoz I am checking in to see if you can please make the suggested change? |
thinkingserious
added
the
status: code review request
|
Go ahead and close this. Saw that other tests had been merged. |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
@thinkingserious 👍 Always appreciate the swag. Thanks. |
|
Hi @cbonoz, Why did you close this PR? With Best Regards, Elmer |
|
Coverage was added by #433 |
|
Cool, thanks for the update :) |
|
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
7 participants
No description provided.