Type Exception Handling for mail/send API call (fix for #510)#518
Closed
aleien wants to merge 2 commits intosendgrid:mainfrom
Closed
Type Exception Handling for mail/send API call (fix for #510)#518aleien wants to merge 2 commits intosendgrid:mainfrom
aleien wants to merge 2 commits intosendgrid:mainfrom
Conversation
thinkingserious
added
the
status: code review request
aleien
force-pushed
the
master
branch
2 times, most recently
from
2240678 to
4c7fe98
Compare
thinkingserious
added
difficulty: hard
Contributor
|
Hi @aleien, thanks for the contribution! Some of this repo has been refactored since this PR was opened. Specifically, much of the logic in |
eshanholtz
added
status: waiting for feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Resolves #510
Checklist
Short description of what this PR does:
mail/sendendpoint. If field value type is incorrect or missing while required user will get appropriate error and it's path. I.e., if user sendssend_atin personalizations param as string instead of error, he will see message:Field: personalizations.send_at contents must be of type Integer