Skip to content

example in subuser breaked into their own examples#396

Closed
seagel wants to merge 4 commits intosendgrid:masterfrom
seagel:master
Closed

example in subuser breaked into their own examples#396
seagel wants to merge 4 commits intosendgrid:masterfrom
seagel:master

Conversation

@seagel
Copy link
Copy Markdown

@seagel seagel commented Oct 31, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@seagel
Copy link
Copy Markdown
Author

seagel commented Nov 3, 2017

Please review this PR @thinkingserious

@thinkingserious
Copy link
Copy Markdown
Contributor

Hi @seagel,

Thanks for the PR!

What issue was this related to?

With Best Regards,

Elmer

@seagel
Copy link
Copy Markdown
Author

seagel commented Nov 4, 2017

the travis ci build not passing

@thinkingserious
Copy link
Copy Markdown
Contributor

Hi @seagel,

My apologies for not being clear. I meant what GitHub issue is this PR solving. If there is not one, could you please provide some explanation on the purpose of this PR?

Thank you!

With Best Regards,

Elmer

@seagel
Copy link
Copy Markdown
Author

seagel commented Nov 4, 2017

Issue no #378

@thinkingserious
Copy link
Copy Markdown
Contributor

Thank you @seagel!

This issue has been solved by #379.

We still appreciate your work and will award you some swag, please fill out this form to redeem.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants