Skip to content

Fixing similar code issue in examples/ips/ips.java#358

Merged
thinkingserious merged 4 commits intosendgrid:masterfrom
jnmau:issue-335
Oct 6, 2018
Merged

Fixing similar code issue in examples/ips/ips.java#358
thinkingserious merged 4 commits intosendgrid:masterfrom
jnmau:issue-335

Conversation

@jnmau
Copy link
Copy Markdown
Contributor

@jnmau jnmau commented Oct 28, 2017

Fix for issue #335. This supersedes PR #352

jnmau added 4 commits October 28, 2017 16:37
Created seperate files for each example
Made the file names more readable
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

@julianjmaurer

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@jpurpura jpurpura added the status: waiting for feedback waiting for feedback from the submitter label Aug 13, 2018
@jpurpura
Copy link
Copy Markdown

Hey @derjayjay, please sign the CLA so that we can continue to merge your code.
Thank you and we appreciate your support!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty status: cla not signed and removed status: code review request requesting a community code review or review from Twilio status: waiting for feedback waiting for feedback from the submitter labels Aug 14, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @derjayjay,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit ffa5a96 into sendgrid:master Oct 6, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @derjayjay,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @derjayjay,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @derjayjay,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants