Skip to content

Adding Docker support.#245

Merged
mbernier merged 2 commits intomasterfrom
docker
Oct 28, 2017
Merged

Adding Docker support.#245
mbernier merged 2 commits intomasterfrom
docker

Conversation

@andy-trimble
Copy link
Copy Markdown
Contributor

@andy-trimble andy-trimble commented Oct 10, 2017

Added support for Java 8. Note that due to Oracle's licensing, this only supports Java 8.

This fixes issue #230

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2017
@andy-trimble
Copy link
Copy Markdown
Contributor Author

@thinkingserious Due to Oracle's license, this is not as flexible as I would like. Additionally, it requires having a Docker Store account. I do not believe that there is an alternate method at this time (but I've been wrong before 😄 .

@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 10, 2017
@thobalose
Copy link
Copy Markdown

Hi @andy-trimble and @thinkingserious

How about using openjdk?

@thinkingserious
Copy link
Copy Markdown
Contributor

Hi @thobalose,

Since one purpose of this Docker build is to ease the process of contributing, it should cover the version of Java we are officially supported.

With Best Regards,

Elmer

@thobalose
Copy link
Copy Markdown

thobalose commented Oct 11, 2017

Hi @thinkingserious ,

Thank you for the reply.

It's just that after what @andy-trimble noted and reading this article, I thought going for openjdk might work to ease the process of contributing. Also, I see that you have openjdk7 in your matrix.

@thinkingserious
Copy link
Copy Markdown
Contributor

I agree @thobalose.

We also need a means to test the Oracle distributions in the Docker build.

@andy-trimble
Copy link
Copy Markdown
Contributor Author

@thinkingserious Unfortunately, there's no legal way to work with Oracle's JDK 7. I can add the OpenJDK though.

@thinkingserious
Copy link
Copy Markdown
Contributor

@andy-trimble,

Ah yes, I just saw that we can't use Oracle's JDK 7 for Travis CI either.

@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @andy-trimble,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants