Applies version range to Jackson dependencies.#227
Applies version range to Jackson dependencies.#227dmitraver wants to merge 95 commits intosendgrid:masterfrom
Conversation
thinkingserious
added
the
status: code review request
thinkingserious
added
difficulty: easy
Update USAGE.md
fix the disappear logo
Update USAGE.md with one period
Update TROUBLESHOOTING.md
Added Javadocs.
Added CODE_OF_CONDUCT.md to root of this repo
| </license> | ||
| </licenses> | ||
| <properties> | ||
| <jackson.version>[2.5.0, 2.5.5]</jackson.version> |
There was a problem hiding this comment.
Should be [2.5.0, 2.6)
There was a problem hiding this comment.
This would take snapshot versions and release candidates and there is no way in maven to disable getting release candidates. This change only picks release versions. I wouldn't use rc and snapshots in stable project.
There was a problem hiding this comment.
How about using [2.5.0, 2.6) along with <snapshots><enabled>false</enabled></snapshots> in the <repository> tag?
There was a problem hiding this comment.
@thinkingserious yeah, I’ve tried disabling it that way but then it picks rc5 version which is not good and there is no way to workaround it afaik. Btw, the most recent version of Jackson is 2.9 something.
Add a template for describing the change(s) being done.
correction of typo in USAGE.md
Split contactdb examples
While I was reading the CONTRIBUTING section to learn how to contribute, I stumbled upon these broken links and typos. Hope this helps!
Update CONTRIBUTING.md
update LICENSE - fix year
Create a PULL_REQUEST_TEMPLATE
Adding Docker support.
Quick and dirty changes to wait for prism
|
@thinkingserious I did a merge of the latest changes, which should fix the build issues here |
|
@thinkingserious if this last change works - we should probably make a change to all the libraries that use prism to just pull their install script each time the way I am doing it in the travis file. Big IF on this working though. |
|
Ok I am giving up and making an issue - hopefully, someone smarter than me can figure this out. |
|
hi @mbernier, the reason why your latest change doesn't work is that you removed the part of script file that runs the prism.That is why you see so many connection exceptions in travis console, prism is installed but it is not running. |
|
Hi @dmitraver, I think this PR has become unmanageable. My apologies! Could you please make a new PR and I'll merge it quickly. Thanks! With Best Regards, Elmer |
18 participants
Fixes #192.
Hi, I applied version range for 2.5 till 2.6.