Alway serialize click-tracking parameters#220
Alway serialize click-tracking parameters#220thinkingserious merged 2 commits intosendgrid:masterfrom
Conversation
Othwerwise setting them to a false value produces an invalid request, because the fields are required. Fixes sendgrid#181
thinkingserious
added
the
status: code review request
|
|
thinkingserious
added
difficulty: medium
|
LGTM |
| ClickTrackingSetting clickTrackingSetting = new ClickTrackingSetting(); | ||
| clickTrackingSetting.setEnable(true); | ||
| clickTrackingSetting.setEnableText(true); | ||
| clickTrackingSetting.setEnableText(false); |
There was a problem hiding this comment.
@thinkingserious This seems like more of a problem with the setEnable function? Why are we doing
clickTrackingSetting.setEnable(true);
and then
clickTrackingSetting.setEnableText(true);
Isn't that redundant?
In Setting we only return enable - I didn't see a place where we return enableText - is that for the "pretty" print? If so, can we modify the class to return enable instead of enableText in that case?
There was a problem hiding this comment.
The real change was removing @JsonInclude(Include.NON_DEFAULT) from ClickTrackingSetting.java to solve issue #181. I think the test was changed to demonstrate that the change worked.
|
I merged in all recent changes in the hopes of getting a passing build! |
5 participants
Othwerwise setting them to a false value produces an invalid request, because
the fields are required.
Fixes #181