Skip to content

Make fine tuning http client possible#119

Closed
ikatkov wants to merge 1 commit intosendgrid:masterfrom
ikatkov:timeouts
Closed

Make fine tuning http client possible#119
ikatkov wants to merge 1 commit intosendgrid:masterfrom
ikatkov:timeouts

Conversation

@ikatkov
Copy link
Copy Markdown

@ikatkov ikatkov commented Jul 13, 2016

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community status: cla needed labels Jul 13, 2016
@dmaicher
Copy link
Copy Markdown
Contributor

I don't think the SendGrid class should have knowledge about the http client which imho is an internal detail of the Client abstraction 😉

I would propose this #158

@ikatkov
Copy link
Copy Markdown
Author

ikatkov commented Oct 11, 2016

@dmaicher I +1 #158
Will kill this one once yours is merged. They will not merge until you do CLA

@ikatkov
Copy link
Copy Markdown
Author

ikatkov commented Oct 11, 2016

see #158

@ikatkov ikatkov closed this Oct 11, 2016
@ikatkov ikatkov deleted the timeouts branch October 11, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants