Skip to content

Moved Mockito to test dependency.#23

Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
twistedpair:master
Oct 12, 2017
Merged

Moved Mockito to test dependency.#23
thinkingserious merged 1 commit intosendgrid:masterfrom
twistedpair:master

Conversation

@twistedpair
Copy link
Copy Markdown
Contributor

@twistedpair twistedpair commented Sep 13, 2017

As referenced by this issue, Mockito should be scoped as a test dependency.

Presently we have to exclude this dependency to use the Sendgride Java Client.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 13, 2017
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Sep 13, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Sep 13, 2017

Awesome, thanks @twistedpair!

Could you please take a minute to sign our CLA so we can merge this?

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 1, 2017
@andy-trimble
Copy link
Copy Markdown
Contributor

andy-trimble commented Oct 10, 2017

LGTM

@thinkingserious thinkingserious merged commit 9205ca4 into sendgrid:master Oct 12, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Oct 12, 2017

Hello @twistedpair,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Oct 12, 2017
@thinkingserious
Version Bump v4.1.1: #23 Moved Mockito to test dependency.
317a74b
@thinkingserious thinkingserious mentioned this pull request Oct 12, 2017
Closed
@twistedpair
Copy link
Copy Markdown
Contributor Author

twistedpair commented Oct 12, 2017

@thinkingserious, thanks. However, I noticed that the sendgrid-java 4.1.1 artifact depends on java-http-client version 4.1.0, so this release has no effect.

The build.gradle also needs to upgraded.

@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Oct 12, 2017

Hi @twistedpair,

Thanks for the heads up. Would you like to make that PR? If not, I'll take care of it.

With Best Regards,

Elmer

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andy-trimble andy-trimble andy-trimble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@twistedpair @SendGridDX @thinkingserious @andy-trimble