Repository navigation
Tests for the github bridge - #706
Merged
Merged
Conversation
rng-dynamics
marked this pull request as draft
September 5, 2021 15:02
Contributor
Author
|
I will mark this as a draft as long as #694 is not merged. |
rng-dynamics
force-pushed
the
dev-github-bridge-tests
branch
from
September 5, 2021 15:15
43cc33f to
8d38e3d
Compare
Contributor
|
@rng-dynamics go ahead and merge what you feel makes sense for the github bridge. You know better than anyone what makes sense there :) |
Contributor
|
Again, sorry but I just can't be a proper project lead currently. I'll come back to it though. |
rng-dynamics
marked this pull request as ready for review
September 13, 2021 19:01
Contributor
Author
|
@MichaelMure, I would need someones approval to merge. (Same as in #694.) |
Contributor
|
Ha right, that should be good now. |
Contributor
|
@MichaelMure I can help you to make this more (helthy) communety driven - but I can't step fully in ... since I already do handle a lof of other projects :) |
Contributor
|
@MichaelMure PS: you can PM me via mail or matrix ( |
Contributor
Author
|
thanks guys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote an integration test for the github bridge. It creates a few issues, comments, labels, edits a comment, and uses two identities. It is a simple "happy path" of an import. If you like it, we can extend it to cover more code of the importer.
This request depends on #694, i.e., #694 should be merged first.