Skip to content

__str__() method for convenience pretty string#10

Merged
selwin merged 19 commits into
selwin:masterfrom
loisaidasam:master
Aug 31, 2014
Merged

__str__() method for convenience pretty string#10
selwin merged 19 commits into
selwin:masterfrom
loisaidasam:master

Conversation

@loisaidasam

Copy link
Copy Markdown
Contributor

Complete with unit tests, version bump, and documentation updates

@selwin

selwin commented Jul 14, 2014

Copy link
Copy Markdown
Owner

@loisaidasam sorry, for some reason I missed your PR. I like these additions, could you please swap the order of appearance to from <DEVICE> / <OS> / <BROWSER> to <BROWSER> / <OS> / <DEVICE>?

Thanks!

@selwin

selwin commented Jul 14, 2014

Copy link
Copy Markdown
Owner

Should we also add a __unicode__ method as well?

@loisaidasam

Copy link
Copy Markdown
Contributor Author

Hey @selwin sorry for the delay. I added a __unicode__() method, but I'm hesitant to switch the order of appearance - can you provide a reason that you'd like them in that order? My natural instinct was to preserve the hierarchical order from largest to smallest.

@selwin

selwin commented Aug 13, 2014

Copy link
Copy Markdown
Owner

@loisaidasam no worries :). Because browser is the most important component, user agent capabilities are mostly dependent on browser type rather than what device they run on. Of course, use cases may vary, I could also be biased because I'm first and foremost a web developer ;)

@selwin

selwin commented Aug 13, 2014

Copy link
Copy Markdown
Owner

@loisaidasam could you also try to merge master into your branch? This PR no longer merges cleanly I'm afraid :(

@loisaidasam

Copy link
Copy Markdown
Contributor Author

Should be good to go! Thanks @selwin

selwin added a commit that referenced this pull request Aug 31, 2014
__str__() method for convenience pretty string
@selwin selwin merged commit 3dede6f into selwin:master Aug 31, 2014
@selwin

selwin commented Aug 31, 2014

Copy link
Copy Markdown
Owner

Merged, thanks!

@loisaidasam

Copy link
Copy Markdown
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants