Fix bug where elements in select2 drop cannot be focused#2846
Conversation
This chrome workaround had the undesired side-effect of preventing anything in the select2 drop from being focused (affected single but not multi selects for some reason). Making the condition more specific to the actual problem being worked around solves this.
This is interesting, as the workaround should only affect cases where the This fix wasn't brought over to Select2 4.0, as it appears that the scrolling issue has been fixed. Perhaps we should just remove the fix in Select2 3.5.x? |
|
Using the latest version of Chrome I was not able to reproduce the bug described in the comments after removing the workaround. So yes I would support removing it, although merging this PR for 3.5.x and leaving the woraround out of 4.x would be maybe a gentler touch. |
|
Either way, it would be awesome to see this resolved in 3.5.x so that we can release the next version of CiviCRM with the official upstream code from select2. |
|
Also just ran across the bug fixed by #2925 |
Fix bug where elements in select2 drop cannot be focused
|
Great, thanks! |
2 participants
Background: CiviCRM builds on select2 by adding some extra filters and controls to the select2 drop area:
Tracking down why the user was being prevented from interacting with the controls, I found that this chrome workaround had the undesired side-effect of preventing anything in the select2 drop from being focused (affected single but not multi selects for some reason). Making the condition more specific to the actual problem being worked around solves this.