Add appProtocol to the mertrics service#2690
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Oct 2, 2024
Merged
Conversation
Signed-off-by: Michael-Kruggel <[email protected]>
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: Michael-Kruggel <[email protected]>
|
Member
|
Ah cool didn't know that existed. Does this still work for clusters where this isn't supported? This seems to only been added with k8s 1.30, we are trying to support the latest 4 versions so, 1.28 and up |
Contributor
Author
|
Yes, this should work on Kubernetes versions 1.18+. 1.18 release notes |
Member
|
Ah sorry misread the page, it went GA with 1.20 not 1.30 like i said earlier, so all good 👍 |
J12934
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael-Kruggel [email protected]
Description
Adds
appProtocolto the metric service for service meshes (e.g. istio) so it knows which protocol to select.istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection
Checklist