Update to latest Kubebuilder (v4) and Go (1.22)#2542
Merged
Weltraumschaf merged 19 commits intosecureCodeBox:mainfrom Jun 28, 2024
Merged
Update to latest Kubebuilder (v4) and Go (1.22)#2542Weltraumschaf merged 19 commits intosecureCodeBox:mainfrom
Weltraumschaf merged 19 commits intosecureCodeBox:mainfrom
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Hash changed as new fields were added to the job spec with default values and so on. This causes the hash to change for each version Signed-off-by: Jannik Hollenbach <[email protected]>
Finally supported by the newer kubebuilder version Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
At least it seems unnecessary. Script came directly from the newer kubebuilder version Signed-off-by: Jannik Hollenbach <[email protected]>
controller-gen now finally omits the empty createdAt timestamps Signed-off-by: Jannik Hollenbach <[email protected]>
kubebuilder now ensures that the correct version is installed which is great! Missed the pinning at first Signed-off-by: Jannik Hollenbach <[email protected]>
This turned out to be a bit tricky because of the deprecation/removal of the controller runtime config handling. I've moved the config handling to use viper now which seems to be working fine. Had to move some stuff around for it, like he metav1.Duration to the default duration. This actually made the code cleaner so no complaints from me. Signed-off-by: Jannik Hollenbach <[email protected]>
J12934
changed the title
Signed-off-by: Jannik Hollenbach <[email protected]>
The empty creation timestamp is no longer auto-generated by kube-builder Signed-off-by: Jannik Hollenbach <[email protected]>
CI was already executing the tests seperatly Signed-off-by: Jannik Hollenbach <[email protected]>
Was there to have the kubebuilder managed config file, but was removed with the migration to viper Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Newer helm unit versions don't include the notes of subcharts anymore Which is good as we don't control it and it's not displayed to users Signed-off-by: Jannik Hollenbach <[email protected]>
Weltraumschaf
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to golang 1.22
While searching for 1.22, I've notitced we had some doc pages linking to kubernetes api pages with hardcoded (and terribly outdated) versions. I think at that point the new version independend links didn't exist. Fixed it in here too.
Kubebuilder and their tooling was having problems with golang 1.22.
I've updated Kubuilder to the latest version for both the operator and auto-discovery/kubernetes which are the two places where we are using it. This was quit a bit of work, see the commits for more context.
Checklist