Slighly Refactor scbctl Code Setup To Avoid Issues With Flags During Testing#2533
Merged
J12934 merged 9 commits intosecureCodeBox:mainfrom Jun 25, 2024
Merged
Conversation
…ition Signed-off-by: Jannik Hollenbach <[email protected]>
… 99% of users Also add some more context to the related error. should hopefully help user understand what wrong there Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
J12934
added
testing
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: Jannik Hollenbach <[email protected]>
J12934
changed the title
scbctl Code Setup To Avoid Issues With Flags During Testing
Freedisch
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@Freedisch i've slightly refactored the code so that the tests can use the actual command without redefining it again in the test.
Also added some more test cases and a
--nameflag to allow user to overwrite the name of the generated scan.Checklist