Skip to content

Feature: Add New Command Line Client scbctl#2514

Merged
J12934 merged 11 commits intosecureCodeBox:mainfrom
Freedisch:scbctl-scans
Jun 22, 2024
Merged

Feature: Add New Command Line Client scbctl#2514
J12934 merged 11 commits intosecureCodeBox:mainfrom
Freedisch:scbctl-scans

Conversation

@Freedisch
Copy link
Member

@Freedisch Freedisch commented Jun 12, 2024 •
edited
Loading

Description

This pull request a new command line client for SecureCodeBox with the scan command allowing users to create scans from their CLI

  • new scan command
  • added test cases
  • updated ci workflow

stream issue: #189

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit dd994b8
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/66770bfe4feae800081032fc

@Weltraumschaf Weltraumschaf added the cli Issues regarding the CLI Integration label Jun 12, 2024
J12934
J12934 requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, tried it locall and it works great :)
A couple of point we should address first but should be ready to merge soon 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

J12934
J12934 requested changes Jun 17, 2024
View reviewed changes
J12934
J12934 reviewed Jun 17, 2024
View reviewed changes
Freedisch added 10 commits June 22, 2024 19:24
@Freedisch @J12934
Feat: Create new scbctl commnad scan
4b8dcce 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
Feat: add test cases for scan command
c6deca5 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
feat: add CI jobs for scbctl test cases
e017ef2 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
add correct license header
d66e878 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
feat: update scan command to receive parameters
67ad3b0 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
update scan test cases for scans parameters
e733102 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
update: add more test cases for scan parameters and fix failling CIs
143c210 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
add scan assertions
241169a 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
fix name typo
01ec80f 
Signed-off-by: freedisch <[email protected]>
@Freedisch @J12934
update go version in scbctl CI
9b09421 
Signed-off-by: freedisch <[email protected]>
@J12934 J12934 merged commit 0a60fbe into secureCodeBox:main Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

No one assigned

Labels

cli Issues regarding the CLI Integration

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Freedisch @J12934 @Weltraumschaf