Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| actionlint | 1 | 5 | 0.32s | ||
| eslint | 27 | 1 | 0.53s | ||
| ✅ JSON | eslint-plugin-jsonc | 13 | 0 | 1.41s | |
| ✅ YAML | prettier | 1 | 0 | 0.74s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
Ilyesbdlala
force-pushed
the
maintenance/helpers-move
branch
from
16a258e to
cdf003c
Compare
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
force-pushed
the
maintenance/helpers-move
branch
from
cdf003c to
e53197a
Compare
Signed-off-by: Ilyes Ben Dlala <[email protected]>
|
J12934
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A while ago I created units tests for helpers.js #2177. However, I forgot that we use two duplicate helpers.js files. One for scanners and one for hooks. This is AFAIK a relict of an older project structure and is no longer required. So I moved helpers.js to tests/integration and changed the references in /scanners to point to the new location. Now both hooks and scanners use the same test file.
Checklist