Merged
Conversation
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| actionlint | 1 | 5 | 0.36s | ||
| eslint | 2 | 1 | 0.53s | ||
| ✅ JSON | eslint-plugin-jsonc | 11 | 0 | 1.06s | |
| prettier | 1 | 1 | 0.74s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
Ilyesbdlala
force-pushed
the
feature/scan-helpers-unittests
branch
from
e150c7c to
c46e163
Compare
Member
|
is this already running / tested in the CI? |
Ilyesbdlala
force-pushed
the
feature/scan-helpers-unittests
branch
from
c46e163 to
30862fa
Compare
Member
Author
Now it is :) |
Ilyesbdlala
force-pushed
the
feature/scan-helpers-unittests
branch
from
30862fa to
481893c
Compare
Ilyesbdlala
changed the title
Ilyesbdlala
force-pushed
the
feature/scan-helpers-unittests
branch
from
2c0a029 to
85b1994
Compare
J12934
requested changes
Feb 5, 2024
basic mockup for @kubernetes/client-node current issue: k8s API calls are still being made Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
This allows passing in the APIs to the respective functions, instead of using a static variable. This simplifies the testing processing and in particular the mocking. Signed-off-by: Ilyes Ben Dlala <[email protected]>
…ing in Mocked APIs Only a basic test is done for now, A higher call/function coverage is TODO Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Allowed functions helpers.js to take in k8s API instances as optional parameters. If not set, a "singleton" of the instance type is created, and used as of then. Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
…lpers.js Signed-off-by: Ilyes Ben Dlala <[email protected]>
* Made use of parameterable k8s API, by mocking them * Included more test cases for cascading scan and failed scans Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
excluded __snapshots__ and __testFiles from the helm-unit-tests makefile target Signed-off-by: Ilyes Ben Dlala <[email protected]>
…rsions to fit upstream version Signed-off-by: Ilyes Ben Dlala <[email protected]>
Better visibility in the GitHub UI logs Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
instead of individual k8sApi (CRD, Batch,Pods) Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is because the test would pass when there is not exception thrown. ref: https://jestjs.io/docs/expect#rejects Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
force-pushed
the
feature/scan-helpers-unittests
branch
from
1cc20f1 to
f338473
Compare
|
J12934
approved these changes
Feb 7, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist