Skip to content

Recurring documentation maintenance#2039

Merged
Weltraumschaf merged 4 commits intomainfrom
maitenance/doc-roulette
Oct 17, 2023
Merged

Recurring documentation maintenance#2039
Weltraumschaf merged 4 commits intomainfrom
maitenance/doc-roulette

Conversation

@Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Oct 17, 2023 •
edited
Loading

Description

closes #1964
Done are the following:

  • Fixed the .gitignore to ignore files generated during the documentation build
  • Added an og:image to improve SEO. closes SEO: Add missing og:graph #1910
  • Fixed The edit url at the bottom of the pages

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala Ilyesbdlala self-assigned this Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for docs-securecodebox ready!

Name Link
🔨 Latest commit aa10c28
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/652e7d1db337cb0007079c8e
😎 Deploy Preview https://deploy-preview-2039--docs-securecodebox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ JAVASCRIPT eslint 3 1 0.63s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Ilyesbdlala
Copy link
Member Author

Ilyesbdlala commented Oct 17, 2023

image
og:image works as intended. It seems to be cropped out in this case. But the image follows the recommanded 1200x630 px size

@Ilyesbdlala Ilyesbdlala force-pushed the maitenance/doc-roulette branch from 87ef58b to aa10c28 Compare October 17, 2023 12:24
@Weltraumschaf Weltraumschaf merged commit d39751e into main Oct 17, 2023
@Weltraumschaf Weltraumschaf deleted the maitenance/doc-roulette branch October 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels

maintenance

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📚 Recurring documentation issue SEO: Add missing og:graph

2 participants

@Ilyesbdlala @Weltraumschaf