Fix helm unit test templates#2008
Merged
Weltraumschaf merged 6 commits intosecureCodeBox:mainfrom Oct 4, 2023
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
Merged
added 2 commits
October 4, 2023 13:50
The check is also broken currently, so to fix the one pipeline blocker disable the other one for now. Will get reverted later. Signed-off-by: Lukas Fischer <[email protected]>
The azure monitor snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <[email protected]>
Weltraumschaf
approved these changes
Oct 4, 2023
The defectdojo snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <[email protected]>
o1oo11oo
force-pushed
the
fix/helm-pipeline-azure-monitor
branch
from
fd442c7 to
4eb9a09
Compare
added 3 commits
October 4, 2023 14:06
The elastic hook snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <[email protected]>
Some juiceshop details changed, which needs to be updated in the test snapshots as well. Signed-off-by: Lukas Fischer <[email protected]>
Signed-off-by: Lukas Fischer <[email protected]>
Weltraumschaf
approved these changes
Oct 4, 2023
Member
Weltraumschaf
left a comment
Weltraumschaf
left a comment
There was a problem hiding this comment.
Would be nice to have a hint in the commit message, why a change fixes something. Makes review easier, if not deep into topic.
Contributor
Author
|
I thought I had put some details at least in most commits, now it's a bit late to change them though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The helm unit tests fail for multiple charts, because the templates don't match anymore, this updates them to match again.
This temporarily disables the license check, which is also broken, will be fixed (and reenabled) by #2006.
Closes #2007
Checklist