Skip to content

Remove 'interval' from required properties as ScheduledScan can be defined by 'schedule' too#1994

Merged
Zero3141 merged 1 commit intosecureCodeBox:mainfrom
Zero3141:bugfix/remove-required-interval
Sep 29, 2023
Merged

Remove 'interval' from required properties as ScheduledScan can be defined by 'schedule' too#1994
Zero3141 merged 1 commit intosecureCodeBox:mainfrom
Zero3141:bugfix/remove-required-interval

Conversation

@Zero3141
Copy link
Contributor

@Zero3141 Zero3141 commented Sep 28, 2023

Description

Fixes #1993

A ScheduledScan can be defined by ìnterval or schedule property. Thus, none of these attributes should be required. We already check for the existance of one of the twos in here

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

…duledScan can be defined by 'schedule' too

Signed-off-by: Heiko Kiesel <[email protected]>
@Zero3141 Zero3141 added the bug Bugs label Sep 28, 2023
@Zero3141 Zero3141 self-assigned this Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 551a0c6
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/65157b08decf990008bb2eb5

@Zero3141 Zero3141 changed the title #1993 Remove 'interval' from required properties as ScheduledScan can be defined by 'schedule' too Remove 'interval' from required properties as ScheduledScan can be defined by 'schedule' too Sep 28, 2023
@Zero3141 Zero3141 merged commit 53e0d29 into secureCodeBox:main Sep 29, 2023
@Zero3141 Zero3141 deleted the bugfix/remove-required-interval branch September 29, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

ScheduledScan requires interval even though a cron schedule is configured

2 participants