Upgrade node to latest LTS in templates#1896
Merged
Ilyesbdlala merged 1 commit intosecureCodeBox:mainfrom Sep 12, 2023
Merged
Conversation
o1oo11oo
added
dependencies
Member
|
As far as I can tell that variable is never used (and is not needed) right ? So we can probably just remove it. |
Contributor
Author
|
Good point, I'm not sure, I didn't check the workflow that far. The other versions are also quite old (usually we use Go 1.19 I think). |
✅ Deploy Preview for docs-securecodebox canceled.
|
o1oo11oo
changed the title
o1oo11oo
force-pushed
the
fix/upgrade-node
branch
from
d95c2ab to
985b704
Compare
o1oo11oo
changed the title
Contributor
Author
|
I opened #1946 to remove the unused version variables, so this now only contains the change of the node version in the templates. |
Missed this node version when upgrading to latest LTS in secureCodeBox#1853 Signed-off-by: Lukas Fischer <[email protected]>
Ilyesbdlala
force-pushed
the
fix/upgrade-node
branch
from
985b704 to
6161bc9
Compare
Ilyesbdlala
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this node version when upgrading to latest LTS in #1853
Relates to #1852
Description
Checklist