Added warning about amass enum not exiting correctly #1895
Merged
Ilyesbdlala merged 1 commit intomainfrom Sep 15, 2023
Merged
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Signed-off-by: Ilyes Ben Dlala <[email protected]>
2c09b4c to
561c5aa
Compare
Weltraumschaf
approved these changes
Sep 5, 2023
Member
Weltraumschaf
left a comment
There was a problem hiding this comment.
How do we track to remove this warning after amass fix?
Member
Author
This should #1864 should be merged first. In hindsight, it may make more sense to just include this commit in the same PR |
Member
Yes, but we need to remember to remove this warning, if Amass fixed that problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1847
Signed-off-by: Ilyes Ben Dlala [email protected]
Description
Checklist