Skip to content

Added warning about amass enum not exiting correctly #1895

Merged
Ilyesbdlala merged 1 commit intomainfrom
maintenance/remove-amass-notice
Sep 15, 2023
Merged

Added warning about amass enum not exiting correctly #1895
Ilyesbdlala merged 1 commit intomainfrom
maintenance/remove-amass-notice

Conversation

@Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Sep 5, 2023

Relates to #1847

Warning
Should be merged after v4.1 release

Signed-off-by: Ilyes Ben Dlala [email protected]

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala Ilyesbdlala self-assigned this Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Ilyesbdlala Ilyesbdlala force-pushed the maintenance/remove-amass-notice branch from 2c09b4c to 561c5aa Compare September 5, 2023 11:55
@Ilyesbdlala Ilyesbdlala changed the title Removed notice about amass not working Added warning about amass enum not exiting correctly Sep 5, 2023
@Ilyesbdlala Ilyesbdlala requested a review from J12934 September 5, 2023 11:57
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we track to remove this warning after amass fix?

@Ilyesbdlala
Copy link
Member Author

How do we track to remove this warning after amass fix?

This should #1864 should be merged first. In hindsight, it may make more sense to just include this commit in the same PR

@Weltraumschaf
Copy link
Member

How do we track to remove this warning after amass fix?

This should #1864 should be merged first. In hindsight, it may make more sense to just include this commit in the same PR

Yes, but we need to remember to remove this warning, if Amass fixed that problem.

@Ilyesbdlala Ilyesbdlala merged commit 68ca625 into main Sep 15, 2023
@Ilyesbdlala Ilyesbdlala deleted the maintenance/remove-amass-notice branch September 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants