Update Juice-Shop Helm chart to use modern Ingress resource#1882
Merged
J12934 merged 5 commits intosecureCodeBox:mainfrom Aug 31, 2023
Merged
Update Juice-Shop Helm chart to use modern Ingress resource#1882J12934 merged 5 commits intosecureCodeBox:mainfrom
J12934 merged 5 commits intosecureCodeBox:mainfrom
Conversation
Signed-off-by: Michael Zeevi <[email protected]>
Signed-off-by: Michael Zeevi <[email protected]>
Contributor
Author
J12934
reviewed
Aug 30, 2023
Member
J12934
left a comment
There was a problem hiding this comment.
Hi! Perfect Thank you 🙌
One small naming consistency thing, everything else is looking good 👍
Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Michael Zeevi <[email protected]>
Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Michael Zeevi <[email protected]>
Signed-off-by: Michael Zeevi <[email protected]>
J12934
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Juice-Shop demo-target application can be installed to Kubernetes using a provided Helm chart which also allows exposing its service online via an Ingress resource. This Ingress resource's template (in the Helm chart) was using an out-dated API version.
This pull request contributes an up to date version of the Ingress resource's template to use the standard
networking.k8s.io/v1API version, instead of the oldnetworking.k8s.io/v1beta1orextensions/v1beta1API versions (conditionally).Testing
In order to test one can install with Helm to a Kubernetes cluster, or render the Kubernetes manifests with
helm templateand compare the YAML to the modern structure here.Click to expand my test details...
With the values file:
deploy with:
helm install my-juice . -f test-values.yamlor run:
which yields: