Skip to content

Allow to configure env and volumes in hooks#1881

Merged
Zero3141 merged 10 commits intosecureCodeBox:mainfrom
Zero3141:feature/configure-env-and-volumes-hooks
Sep 1, 2023
Merged

Allow to configure env and volumes in hooks#1881
Zero3141 merged 10 commits intosecureCodeBox:mainfrom
Zero3141:feature/configure-env-and-volumes-hooks

Conversation

@Zero3141
Copy link
Contributor

Description

Implements #1763. Volumes and VolumeMounts (here) are now configurable with hook.extraVolumes and hook.extraVolumeMounts. Environment variables (here) can be added in hook.env.

Supported hooks:

  • cascading-scans
  • finding-post-processing
  • generic-webhook
  • notification
  • persistence-azure-monitor
  • persistence-defectdojo
  • persistence-elastic
  • update-field-hook

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Zero3141 Zero3141 added the enhancement New feature or request label Aug 29, 2023
@Zero3141 Zero3141 self-assigned this Aug 29, 2023
@Zero3141 Zero3141 marked this pull request as draft August 29, 2023 14:18
@Zero3141 Zero3141 changed the title Feature/configure env and volumes hooks Allow to configure env and volumes in hooks Aug 29, 2023
@Zero3141 Zero3141 force-pushed the feature/configure-env-and-volumes-hooks branch from 7ea7990 to 98822f2 Compare August 29, 2023 14:24
Signed-off-by: Heiko Kiesel <[email protected]>
@Zero3141 Zero3141 marked this pull request as ready for review August 30, 2023 12:08
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working nicely 🚀

@Zero3141 Zero3141 merged commit 8f9cc6e into secureCodeBox:main Sep 1, 2023
@Zero3141 Zero3141 deleted the feature/configure-env-and-volumes-hooks branch September 1, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants